Merged
Conversation
robert3005
approved these changes
Feb 9, 2018
robert3005
changed the title
|
I don't think this is correct. We want to be keeping all of our Kubernetes references locked down - see #299 (comment) and #300 for how we've done this before. |
|
While I agree that we do want to keep our k8s version we also have to think about maintainability. We had two bugs because of not careful merge from upstream in k8s. Therefore, I think it's reasonable to bring changes from upstream that do not touch the core logic but minimize the chance for future conflicts (in this case SparkSubmit and this dockerfile). The end state will not differ but the path by which you get there will be vastly simpler for the maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docker image for kubernetes is not currently building because when the merge with upstream changed the output path from
dockerfilestokubernetes/docker, the path in the Dockerfile was not updated to match.@robert3005 @jamding